Obddiag has taken my patch and updated the official source to not send the test packet when J1850 is explicitly set. That solves one problem.
"update explicitly set protocol handling"
https://github.com/ObdDiag-Net/allpro/t ... dapter/obd
Allpro development
- antus
- Site Admin
- Posts: 8252
- Joined: Sat Feb 28, 2009 8:34 pm
- cars: TX Gemini 2L Twincam
TX Gemini SR20 18psi
Datsun 1200 Ute
Subaru Blitzen '06 EZ30 4th gen, 3.0R Spec B - Contact:
Re: obdpro
Have you read the FAQ? For lots of information and links to significant threads see here: http://pcmhacking.net/forums/viewtopic.php?f=7&t=1396
- Holden202T
- Posts: 10311
- Joined: Sat Feb 28, 2009 9:05 pm
- Location: Tenambit, NSW
- Contact:
Re: obdpro
good to see your getting some love back
No matter what the question is, the answer is always more horsepower!
Just starting out? Have a read of the getting started guide
Basic tuning of a delco ECM with $12P thread
Advanced tuning of a delco ECM with $12P thread
Just starting out? Have a read of the getting started guide
Basic tuning of a delco ECM with $12P thread
Advanced tuning of a delco ECM with $12P thread
- antus
- Site Admin
- Posts: 8252
- Joined: Sat Feb 28, 2009 8:34 pm
- cars: TX Gemini 2L Twincam
TX Gemini SR20 18psi
Datsun 1200 Ute
Subaru Blitzen '06 EZ30 4th gen, 3.0R Spec B - Contact:
Re: obdpro
Its been a while since I looked at this, but tonight I tried various different ways of making the concept of variable speed vpw fit in to the object orientated code base of the obdpro. After several false starts and hours trying to figure out why I could not set my vpw speed flag to 1 (because I had appended the definition of the setting to the end of the list, not the end of the booleans at the top!) things came together.
I have extended the protocol adapter class to support setSpeed (which does nothing for the other adapters). But then the VPW adapter calls a function which tests if 4x is turned on or not and sets all the timings appropriately.
Heres the test.. This shows the code in the protocol function which calls setSpeed, the terminal window I was testing from (and some bool setting debugging). Essentially ive set VPW, displayed the protocol name, set V1 for vpw high speed, displayed the protocol again which now includes '4X' on the end, then sent a packet which is logged at the protocol analyser showing that it was indeed valid VPW 4x that came out of it. Win!
I have extended the protocol adapter class to support setSpeed (which does nothing for the other adapters). But then the VPW adapter calls a function which tests if 4x is turned on or not and sets all the timings appropriately.
Heres the test.. This shows the code in the protocol function which calls setSpeed, the terminal window I was testing from (and some bool setting debugging). Essentially ive set VPW, displayed the protocol name, set V1 for vpw high speed, displayed the protocol again which now includes '4X' on the end, then sent a packet which is logged at the protocol analyser showing that it was indeed valid VPW 4x that came out of it. Win!
Have you read the FAQ? For lots of information and links to significant threads see here: http://pcmhacking.net/forums/viewtopic.php?f=7&t=1396
- antus
- Site Admin
- Posts: 8252
- Joined: Sat Feb 28, 2009 8:34 pm
- cars: TX Gemini 2L Twincam
TX Gemini SR20 18psi
Datsun 1200 Ute
Subaru Blitzen '06 EZ30 4th gen, 3.0R Spec B - Contact:
Re: obdpro
New command ATV for toggling VPW high speed, and ATR for toggling raw payload support. And buffer size changes which gets me up to 128 byte packets. Not ideal, but good enough to get started.
NO DATA means no response from the pcm. Thats fine, there is nothing on the data bus, Im just passively reading the output with the logic analyser.
NO DATA means no response from the pcm. Thats fine, there is nothing on the data bus, Im just passively reading the output with the logic analyser.
Code: Select all
ATZ
OK
ELM327 v1.4
>AT#1
Copyright (c) 2009-2016 ObdDiag.Net, 2016 PCMHacking.net
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
>ATSP2
OK
>ATDP
SAE J1850 VPW
>6C10F100112233445566778899AABBCCDDEEFF (this outputs at 1x, and with an incorrect 3 bytes header inserted at the front by the hardware)
NO DATA
>ATR1 (sets raw payload, hardware no longer adds the 3 byte header)
OK
>6C10F100112233445566778899AABBCCDDEEFF (this outputs as is, at 1X)
NO DATA
>ATV1 (this sets VPW 4X)
OK
>6C10F100112233445566778899AABBCCDDEEFF (this outputs as is, at 4X)
NO DATA
Have you read the FAQ? For lots of information and links to significant threads see here: http://pcmhacking.net/forums/viewtopic.php?f=7&t=1396
- antus
- Site Admin
- Posts: 8252
- Joined: Sat Feb 28, 2009 8:34 pm
- cars: TX Gemini 2L Twincam
TX Gemini SR20 18psi
Datsun 1200 Ute
Subaru Blitzen '06 EZ30 4th gen, 3.0R Spec B - Contact:
Re: obdpro
Just to close this off, this work was successful, and this and large packet support ended up in the allpro, which can now flash with pcmhammer
Have you read the FAQ? For lots of information and links to significant threads see here: http://pcmhacking.net/forums/viewtopic.php?f=7&t=1396