Data logger for P01 and P59

They go by many names, P01, P59, VPW, '0411 etc. Also covering E38 and newer here.
User avatar
joukoy
Posts: 392
Joined: Tue Dec 17, 2019 3:27 am
cars: Pontiac Firebird 1978

Re: Data logger for P01 and P59

Post by joukoy »

Version 9 works maybe one minute until it says "index out of bounds" or something.
But still, it works.

Version 11... see the log.
I believe this have something to do with regional settings (?)

Edit:
System.IO.DirectoryNotFoundException: Polun C:\Users\Jouko\Documents\20200213_1703_General.json.csv osaa ei löytynyt.
in English:
System.IO.DirectoryNotFoundException: Path C:\Users\Jouko\Documents\20200213_1703_General.json.csv part not found.
Attachments
pcmlogger.txt
(3.95 KiB) Downloaded 263 times
User avatar
NSFW
Posts: 679
Joined: Fri Feb 02, 2018 3:13 pm

Re: Data logger for P01 and P59

Post by NSFW »

It should be possible to fix that by clicking the "Set Folder" button and choosing a valid directory.

What is your "Documents" directory really named? I'll report this bug to Microsoft, because the app uses an API that is supposed to honor regional settings:

Code: Select all

            string logDirectory = LoggerConfiguration.LogDirectory;
            if (string.IsNullOrWhiteSpace(logDirectory))
            {
                logDirectory = Environment.GetFolderPath(Environment.SpecialFolder.MyDocuments);
                LoggerConfiguration.LogDirectory = logDirectory;
            }
Please don't PM me with technical questions - start a thread instead, and send me a link to it. That way I can answer in public, and help other people who have the same question. Thanks!
User avatar
Gampy
Posts: 2330
Joined: Sat Dec 15, 2018 7:38 am

Re: Data logger for P01 and P59

Post by Gampy »

joukoy,

What Operating System??
Are you running it in a Virtual Machine??
Intelligence is in the details!

It is easier not to learn bad habits, then it is to break them!

If I was here to win a popularity contest, their would be no point, so I wouldn't be here!
User avatar
joukoy
Posts: 392
Joined: Tue Dec 17, 2019 3:27 am
cars: Pontiac Firebird 1978

Re: Data logger for P01 and P59

Post by joukoy »

joukoy wrote:Version 9 works maybe one minute until it says "index out of bounds" or something.
But still, it works.

Version 11... see the log.
I believe this have something to do with regional settings (?)

Edit:
System.IO.DirectoryNotFoundException: Polun C:\Users\Jouko\Documents\20200213_1703_General.json.csv osaa ei löytynyt.
in English:
System.IO.DirectoryNotFoundException: Path C:\Users\Jouko\Documents\20200213_1703_General.json.csv part not found.
SORRY!
False alarm, I copied folder from one computer to another and didn't change folder at any moment.
It was automatically set to C:\Users\Jouko\Documents\ in first pc, but then logged on with different username on second computer.

Now it works fine.
User avatar
NSFW
Posts: 679
Joined: Fri Feb 02, 2018 3:13 pm

Re: Data logger for P01 and P59

Post by NSFW »

Glad to hear it!
Please don't PM me with technical questions - start a thread instead, and send me a link to it. That way I can answer in public, and help other people who have the same question. Thanks!
User avatar
joukoy
Posts: 392
Joined: Tue Dec 17, 2019 3:27 am
cars: Pontiac Firebird 1978

Re: Data logger for P01 and P59

Post by joukoy »

Scott68B wrote:Had a chance to play with it further this weekend. I was out for over an hour drive yesterday with no issues and went for another drive today. I encountered the following. Hope it is of some help.

Scott

Code: Select all

[02:26:59:080]  TX: 2A01FEFDFC 
[02:26:59:240]  RX: 6C F0 10 6A FE 24 D7 0A B9 02 02
[02:26:59:240]  RX: 6C F0 10 6A FD AB 7B 59 FF 16 CF
[02:26:59:240]  RX: 6C F0 10 6A FC 8B 7A 8B 7C 79 1C
[02:26:59:240]  ReadLogData: 6C F0 10 6A FE 24 D7 0A B9 02 02
[02:26:59:240]  ReadLogData: 6C F0 10 6A FD AB 7B 59 FF 16 CF
[02:26:59:240]  ReadLogData: 6C F0 10 6A FC 8B 7A 8B 7C 79 1C
[02:26:59:240]  Requesting row...
[02:26:59:240]  TX: 2A01FEFDFC 
[02:26:59:419]  RX: 6C F0 10 6A FE 24 DA 09 D4 02 02
[02:26:59:419]  RX: 6C F0 10 6A FD 6D 79 58 FF 16 CF
[02:26:59:419]  RX: 6C F0 10 6A FC 8B 80 8B 7B 79 1B
[02:26:59:419]  ReadLogData: 6C F0 10 6A FE 24 DA 09 D4 02 02
[02:26:59:419]  ReadLogData: 6C F0 10 6A FD 6D 79 58 FF 16 CF
[02:26:59:419]  ReadLogData: 6C F0 10 6A FC 8B 80 8B 7B 79 1B
[02:26:59:423]  Requesting row...
[02:26:59:423]  TX: 2A01FEFDFC 
[02:26:59:591]  RX: 6C F0 10 6A
[02:26:59:591]  RX: 6C F0 10 6A FD 20 80 5A FF 14 CF
[02:26:59:591]  RX: 6C F0 10 6A FC 8B 80 8B 80 79 1B
[02:26:59:591]  ReadLogData: 6C F0 10 6A
[02:26:59:624]  System.IndexOutOfRangeException: Index was outside the bounds of the array.
   at PcmHacking.Message.get_Item(Int32 index)
   at PcmHacking.Protocol.TryParseRawLogData(Message message, RawLogData& rawLogData)
   at PcmHacking.Vehicle.<ReadLogData>d__46.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
   at PcmHacking.Logger.<GetNextRow>d__5.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
   at PcmHacking.MainForm.<LoggingThread>d__23.MoveNext() in C:\GitHub\PcmHacks\Apps\PcmLogger\MainForm.cs:line 287
In what version this is fixed?
Pcmhammer 11, pcmlogger can run only few minutes and then:

Code: Select all

[01.31.17.022]  Requesting row...
[01.31.17.022]  TX: STPX H:6C10F0, R:2, D:2A01FEFD
[01.31.17.132]  RX: 6C F0 10 6A FE 08 8F 02 75 26 0C
[01.31.17.132]  RX: 6C F0 10 6A
[01.31.17.132]  ReadLogData: 6C F0 10 6A FE 08 8F 02 75 26 0C
[01.31.17.132]  ReadLogData: 6C F0 10 6A
[01.31.17.163]  System.IndexOutOfRangeException: Indeksi oli taulukon alueen ulkopuolella.
   kohteessa PcmHacking.Message.get_Item(Int32 index)
   kohteessa PcmHacking.Protocol.TryParseRawLogData(Message message, RawLogData& rawLogData)
   kohteessa PcmHacking.Vehicle.<ReadLogData>d__45.MoveNext()
--- Pinon jäljityksen loppu aiemmasta sijainnista, jossa palautettiin poikkeus ---
   kohteessa System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   kohteessa System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   kohteessa System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
   kohteessa PcmHacking.Logger.<GetNextRow>d__5.MoveNext()
--- Pinon jäljityksen loppu aiemmasta sijainnista, jossa palautettiin poikkeus ---
   kohteessa System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   kohteessa System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   kohteessa System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
   kohteessa PcmHacking.MainForm.<LoggingThread>d__25.MoveNext() tiedostossa C:\GitHub\PcmHacks\Apps\PcmLogger\MainForm.cs:rivillä 342
[01.31.20.426]  TX: STPX H:6C10F0, R:2, D:2CFE4A000CFFFF

User avatar
NSFW
Posts: 679
Joined: Fri Feb 02, 2018 3:13 pm

Re: Data logger for P01 and P59

Post by NSFW »

The fix will be in 12.
Please don't PM me with technical questions - start a thread instead, and send me a link to it. That way I can answer in public, and help other people who have the same question. Thanks!
brandonwh64
Posts: 26
Joined: Mon Dec 31, 2018 9:17 pm
cars: building a 1965 F100 with a 5.3L LS

Re: Data logger for P01 and P59

Post by brandonwh64 »

This logger has been working great for me. Using https://datazap.me/ allows you to put these log files into graph/timeline form.

Now I was wondering if anyone has compiled a list of PIDs for the P01/P59 along with their descriptions? Would like to log your VE table/TAFR while you drive and it log RPM at the same time which is already a possibility but I do not know the VE table PID. I got the torque app to log VE but it does not give the PID it uses.
bubba2533
Posts: 498
Joined: Wed Apr 11, 2018 8:50 am
cars: 03 Chevy S10 Turbo V6

Re: Data logger for P01 and P59

Post by bubba2533 »

I'm interested in increasing the speed of logging. I'm using hptuners for my logging right now, and it's quite a low logging rate. Also I think being able to add my own parameters via memory addresses would be a big help in terms of reverse engineering the OS.

I can't really help with the development of the software, but I can support doing testing.

I was thinking of doing a baseline of logging speed. Not sure how I should do that but I figured it would be good to have.
LS1 Boost OS V3 Here. For feature suggestions post in here Development Thread. Support future development ->Patreon.
jlvaldez
Posts: 155
Joined: Mon Feb 11, 2019 12:48 pm
cars: '01 - Corvette Z06
'20 - Sierra Denali
'03 - Volvo S80 T6
'16 - Accord V6
Location: DFW, Texas

Re: Data logger for P01 and P59

Post by jlvaldez »

Remember the data bus is a pretty abysmally slow 10.4 kbps, and has lots of other data to transfer too. Higher data rates are simply not possible if you're logging several PIDs
Post Reply