PCM Hammer Suite development

They go by many names, P01, P59, VPW, '0411 etc . Circa 1999 to 2006. All VPW OBD2 PCMs.
Posts: 567
Joined: Sat Dec 15, 2018 7:38 am

Re: PCM Hammer Suite development

Postby Gampy » Thu May 21, 2020 1:25 am

Just to put my PR#171 dilemma out there ... I pondered that or this,
Code: Select all
diff --git a/Apps/PcmLibrary/CKernelWriter.cs b/Apps/PcmLibrary/CKernelWriter.cs
index 68f5750..8c62040 100644
--- a/Apps/PcmLibrary/CKernelWriter.cs
+++ b/Apps/PcmLibrary/CKernelWriter.cs
@@ -254,7 +254,7 @@ namespace PcmHacking
                         {
                             Utility.ReportRetryCount("Write", messageRetryCount, flashChip.Size, this.logger);
                         }
-                        return true;
+                        break;
                     }
                 }

@@ -341,11 +341,6 @@ namespace PcmHacking
             {
                 this.logger.AddUserMessage("Flash successful!");

-                if (messageRetryCount > 2)
-                {
-                    logger.AddUserMessage("Write request messages had to be re-sent " + messageRetryCount + " times.");
-                }
-
                 return true;
             }
I'm not angry, I'm a blatant, driven, passionate individual that is extremely intense!

Posts: 567
Joined: Sat Dec 15, 2018 7:38 am

Re: PCM Hammer Suite development

Postby Gampy » Thu May 21, 2020 5:38 am

Bah humbug, I just realized my PR#175 (now merged) conflicted with my previously existing PR#168.

I have updated PR#168, my apologies.
I'm not angry, I'm a blatant, driven, passionate individual that is extremely intense!

Previous

Return to GM LS1 512Kbyte and 1Mbyte

Who is online

Users browsing this forum: joukoy and 2 guests