PCM Hammer Suite development

They go by many names, P01, P59, VPW, '0411 etc . Circa 1999 to 2006. All VPW OBD2 PCMs.
User avatar
Posts: 844
Joined: Sat Dec 15, 2018 7:38 am

Re: PCM Hammer Suite development

Postby Gampy » Thu Dec 31, 2020 1:37 am

Ah ha, I thought I remember you upping it to 16384 ...

So, I guess I've combined them ... The Application polls with it while the Colonel wacks it out back. :roll:
Windows 10 is like an off idle flat spot ... It stumbles when it's time to go!

User avatar
Posts: 844
Joined: Sat Dec 15, 2018 7:38 am

Re: PCM Hammer Suite development

Postby Gampy » Fri Jan 01, 2021 2:15 am

Two PR's up ...

PR#215 - Added option for linker map file.
Added option to Build.cmd to disable creation of kernel.map

PR#216 - Demote Enable4x to device instance lifespan.
Changed the lifespan to the life of the currently selected device instance.

A conflicting one to follow when these get merged or rejected ...
Windows 10 is like an off idle flat spot ... It stumbles when it's time to go!

User avatar
Posts: 466
Joined: Fri Feb 02, 2018 3:13 pm

Re: PCM Hammer Suite development

Postby NSFW » Sat Jan 02, 2021 7:05 am

PCM Hammer (Beta) is live in the Windows Store.

This was built from the develop branch about a week ago, so it doesn't include the new data logging stuff, or the status strip. I plan to merge those changes (and probably the two that Gampy mentioned above) and then resubmit to find out how the update process works.

Edit: I don't kow where the siezure warning came from. :comp:

PcmHammerInTheWindowsStore.png
PcmHammerInTheWindowsStore.png (245.59 KiB) Viewed 304 times


PcmHammerInTheWindowsStore2.png
PcmHammerInTheWindowsStore2.png (163.83 KiB) Viewed 304 times
Please don't PM me with technical questions - start a thread instead, and send me a link to it. That way I can answer in public, and help other people who have the same question. Thanks!

User avatar
Posts: 844
Joined: Sat Dec 15, 2018 7:38 am

Re: PCM Hammer Suite development

Postby Gampy » Sat Jan 02, 2021 9:20 am

Awesome!

Personally if it were me, I would merge one PR, then re-submit, then merge the next PR, and re-submit again ... To take advantage, educate and streamline the process!
But that's me, that's how I operate ...

As stated previously, I have another pr to follow conflict merged or rejection, however, the only one I would push for in the next release would be PR#216, it is a bugfix in disguise!
Windows 10 is like an off idle flat spot ... It stumbles when it's time to go!

Posts: 188
Joined: Thu Feb 13, 2020 11:32 pm

Re: PCM Hammer Suite development

Postby ironduke » Sat Jan 02, 2021 12:21 pm

I admit, that is pretty neat to see.. First app I've ever downloaded from the windows app store, hopefully the only..

Is there a version number somewhere? for when there are updates? Just go by the 12/23/20 date on the top?? Used to have t he version there before I believe..

User avatar
Posts: 844
Joined: Sat Dec 15, 2018 7:38 am

Re: PCM Hammer Suite development

Postby Gampy » Sat Jan 02, 2021 12:31 pm

Releases have the version number in the title bar as well as in the logs.
Previews (Betas) have the build date in the title bar as well as in the logs.
Windows 10 is like an off idle flat spot ... It stumbles when it's time to go!

Posts: 188
Joined: Thu Feb 13, 2020 11:32 pm

Re: PCM Hammer Suite development

Postby ironduke » Sat Jan 02, 2021 2:06 pm

Gampy wrote:Releases have the version number in the title bar as well as in the logs.
Previews (Betas) have the build date in the title bar as well as in the logs.


I haven't looked at logs, merely downloaded the windows app version and this is what I was asking about.. There isn't a version number on the title bar.. Least not one that I saw.. I did see the date I mentioned though.. On the home desktop so I can't really try a log just yet..

User avatar
Posts: 844
Joined: Sat Dec 15, 2018 7:38 am

Re: PCM Hammer Suite development

Postby Gampy » Sat Jan 02, 2021 2:49 pm

No need to look at logs, both the title bar and logs show the same thing ...

ironduke wrote:Is there a version number somewhere?
Depends on if it's a preview or release.

ironduke wrote:Just go by the 12/23/20 date on the top??
If it's a preview.

ironduke wrote:Used to have t he version there before I believe..
Releases still do.

Clear ??

[edit]
Oh yea, there is the Zip filename as well ...

Your question makes me think we should have the zip file, title bar and logs all show the same thing. Hmmmm. :study:
Windows 10 is like an off idle flat spot ... It stumbles when it's time to go!

User avatar
Posts: 466
Joined: Fri Feb 02, 2018 3:13 pm

Re: PCM Hammer Suite development

Postby NSFW » Mon Jan 04, 2021 4:56 pm

Yeah, "official" builds will have a release number in the title bar. Those are builds that are intended for wide use.

Test builds just have a date and time.

I didn't get around to merging changes or updating the store yet, but hopefully tomorrow after work...
Please don't PM me with technical questions - start a thread instead, and send me a link to it. That way I can answer in public, and help other people who have the same question. Thanks!

User avatar
Posts: 844
Joined: Sat Dec 15, 2018 7:38 am

Re: PCM Hammer Suite development

Postby Gampy » Tue Jan 12, 2021 10:26 pm

So I was cruising code trying to educate a brain cell or two when I ran across this,

In MainFormBase.cs, protected async Task<bool> InitializeCurrentDevice()
Code: Select all
            this.Invoke((MethodInvoker)delegate ()
            {
                this.EnableUserInput();
            });
And in PcmHammer MainForm.cs
Code: Select all
        /// <summary>
        /// Enable the buttons when a long-running operation completes.
        /// </summary>
        protected override void EnableUserInput()
        {
            this.Invoke((MethodInvoker)delegate ()
            {
                this.interfaceBox.Enabled = true;

                // The operation buttons have to be enabled/disabled individually
                // (rather than via the parent GroupBox) because we sometimes want
                // to enable the re-initialize operation while the others are disabled.
                this.readEntirePCMToolStripMenuItem.Enabled = true;
                this.verifyEntirePCMToolStripMenuItem.Enabled = true;
                this.modifyVINToolStripMenuItem.Enabled = true;
                this.writeParmetersCloneToolStripMenuItem.Enabled = true;
                this.writeOSCalibrationBootToolStripMenuItem.Enabled = true;
                this.writeFullToolStripMenuItem.Enabled = true;
                this.settingsToolStripMenuItem.Enabled = true;
                this.saveToolStripMenuItem.Enabled = true;
                this.exitApplicationToolStripMenuItem.Enabled = true;
                this.userDefinedKeyToolStripMenuItem.Enabled = true;

                this.readPropertiesButton.Enabled = true;

                this.testWriteButton.Enabled = true;
                this.writeCalibrationButton.Enabled = true;
                this.exitKernelButton.Enabled = true;
                this.reinitializeButton.Enabled = true;
            });
        }

Where MainFormBase.InitializeCurrentDevice() wraps the call to EnableUserInput() in a MethodInvoker, and PcmHammer.MainForm.EnableUserInput() also wraps everything in a MethodInvoker.

Seems to me the MethodInvoker wrap in PcmHammer.MainForm.EnableUserInput() is redundant.

I ask because I do not know!
Windows 10 is like an off idle flat spot ... It stumbles when it's time to go!

PreviousNext

Return to GM LS1 512Kbyte and 1Mbyte

Who is online

Users browsing this forum: No registered users and 4 guests