PCM Hammer Suite development

They go by many names, P01, P59, VPW, '0411 etc. Also covering E38 and newer here.
User avatar
Gampy
Posts: 2330
Joined: Sat Dec 15, 2018 7:38 am

Re: PCM Hammer Suite development

Post by Gampy »

Just to put my PR#171 dilemma out there ... I pondered that or this,

Code: Select all

diff --git a/Apps/PcmLibrary/CKernelWriter.cs b/Apps/PcmLibrary/CKernelWriter.cs
index 68f5750..8c62040 100644
--- a/Apps/PcmLibrary/CKernelWriter.cs
+++ b/Apps/PcmLibrary/CKernelWriter.cs
@@ -254,7 +254,7 @@ namespace PcmHacking
                         {
                             Utility.ReportRetryCount("Write", messageRetryCount, flashChip.Size, this.logger);
                         }
-                        return true;
+                        break;
                     }
                 }

@@ -341,11 +341,6 @@ namespace PcmHacking
             {
                 this.logger.AddUserMessage("Flash successful!");

-                if (messageRetryCount > 2)
-                {
-                    logger.AddUserMessage("Write request messages had to be re-sent " + messageRetryCount + " times.");
-                }
-
                 return true;
             }
Intelligence is in the details!

It is easier not to learn bad habits, then it is to break them!

If I was here to win a popularity contest, their would be no point, so I wouldn't be here!
User avatar
Gampy
Posts: 2330
Joined: Sat Dec 15, 2018 7:38 am

Re: PCM Hammer Suite development

Post by Gampy »

Bah humbug, I just realized my PR#175 (now merged) conflicted with my previously existing PR#168.

I have updated PR#168, my apologies.
Intelligence is in the details!

It is easier not to learn bad habits, then it is to break them!

If I was here to win a popularity contest, their would be no point, so I wouldn't be here!
User avatar
Gampy
Posts: 2330
Joined: Sat Dec 15, 2018 7:38 am

Re: PCM Hammer Suite development

Post by Gampy »

I have a User Defined Key feature ready to release that will cover this Added ability to unlock PCM with erased parameter block. #181 PR by dzidaV8.

Just waiting on prerequisites and or conflicts to either be merged or rejected.

At the moment it's third in queue.

-Enjoy
Intelligence is in the details!

It is easier not to learn bad habits, then it is to break them!

If I was here to win a popularity contest, their would be no point, so I wouldn't be here!
User avatar
antus
Site Admin
Posts: 8237
Joined: Sat Feb 28, 2009 8:34 pm
cars: TX Gemini 2L Twincam
TX Gemini SR20 18psi
Datsun 1200 Ute
Subaru Blitzen '06 EZ30 4th gen, 3.0R Spec B
Contact:

Re: PCM Hammer Suite development

Post by antus »

Cool looks good!
Have you read the FAQ? For lots of information and links to significant threads see here: http://pcmhacking.net/forums/viewtopic.php?f=7&t=1396
User avatar
NSFW
Posts: 679
Joined: Fri Feb 02, 2018 3:13 pm

Re: PCM Hammer Suite development

Post by NSFW »

Sorry I've been out of the loop lately, I'll find some time for these pull requests this weekend.
Please don't PM me with technical questions - start a thread instead, and send me a link to it. That way I can answer in public, and help other people who have the same question. Thanks!
User avatar
NSFW
Posts: 679
Joined: Fri Feb 02, 2018 3:13 pm

Re: PCM Hammer Suite development

Post by NSFW »

That weekend sure went by quickly. :O

Maybe this weekend...
Please don't PM me with technical questions - start a thread instead, and send me a link to it. That way I can answer in public, and help other people who have the same question. Thanks!
User avatar
Gampy
Posts: 2330
Joined: Sat Dec 15, 2018 7:38 am

Re: PCM Hammer Suite development

Post by Gampy »

Time flies when you're having fun ...
Intelligence is in the details!

It is easier not to learn bad habits, then it is to break them!

If I was here to win a popularity contest, their would be no point, so I wouldn't be here!
User avatar
Gampy
Posts: 2330
Joined: Sat Dec 15, 2018 7:38 am

Re: PCM Hammer Suite development

Post by Gampy »

So what's happening with PR 160, 168, 169, 171, are they being silently pondered, or silently rejected??

Would be nice to know so adjustments can be made accordingly to move forward, progress is being held up.
Intelligence is in the details!

It is easier not to learn bad habits, then it is to break them!

If I was here to win a popularity contest, their would be no point, so I wouldn't be here!
User avatar
NSFW
Posts: 679
Joined: Fri Feb 02, 2018 3:13 pm

Re: PCM Hammer Suite development

Post by NSFW »

It's not you, it's me! I was looking at the "flash successful redux" change when I got derailed. I'll get back to it.
Please don't PM me with technical questions - start a thread instead, and send me a link to it. That way I can answer in public, and help other people who have the same question. Thanks!
User avatar
Gampy
Posts: 2330
Joined: Sat Dec 15, 2018 7:38 am

Re: PCM Hammer Suite development

Post by Gampy »

Thank you very much for letting me know ...

That's life, it happens!

Just to reiterate my own dilemma on that (flash successful redux) PR #171 See This

-Enjoy
Intelligence is in the details!

It is easier not to learn bad habits, then it is to break them!

If I was here to win a popularity contest, their would be no point, so I wouldn't be here!
Post Reply