Universalpatcher with Logger & Analyzer

[joukoy]

Yup, the crash on disconnect while VPW logger is running is related to J2534.
The dates are related to J2534 ...

The rest happens with both ...

I'm not going to dig into joukoy's code, however I replaced the J2534.dll in Joukoy\UniversalPatcher\PCMHammer (only one I found) and it still acts the same, it is the most simplest interoperability wrapper possible, no issues with it elsewhere ...
Not saying it cannot be the wrapper or driver, it still could be.

The logger app is fragile.

Version 0.20.10 should fix these issues.
I believe it was crashing because logger thread was using external dll functions AND updating UI (logs, debug logs)
Now all logging is using events, which separates threads completely.

[Gampy]

Awesome.

Will test shortly.

[Gampy]

It does work much better, there is still an issue with the tab/button following ...

Operationally it is a bit funky,
1. Open Logger, it'll be on the Log tab, the button is Start Logging
2. Select Settings tab - Button is Start Logging
3. Setup your device
4. Select Advanced tab - button is Start Logging
5. Check Enable VPW console
6. Check Timestamps
7. Select Connect ... It logs the OsID.
8. Select Start Logging ... You get No profile configured
9. Select Analyzer tab - Button changes to Start Analyzer
10. Select Advanced tab
11. Select Start Analyzer - It works.
12. Select Stop Analyzer - The button changes to Start Logging ...
13. Select Start Logging - it works!

It still crashes when disconnecting while logging, stop logging before disconnecting.

Can we please get options for a simple uncluttered log like,

[10:40:38:025] 6C 10 F0 3C 0A
[10:40:38:025] 6C F0 10 7C 0A 00 BA 67 3D

Nothing more is needed, the rest is just clutter IMO.

With the time stamp simply done like,

Code: Select all

            string timestamp = DateTime.Now.ToString("hh:mm:ss:fff");

The decimal values without byte separation are useless IMO ... Besides most everyone that does this stuff (except me) is capable of converting 6C -> 108 in their head.

[joukoy]

Version 0.20.11

Now Analyzer have own start/stop button, and it can run concurrent with logger.
Timestamps fixed.
And some other mods

[Gampy]

Cannot get it to work at all ...

1. Open Logger - it will be on the Log tab
2. Select Settings - Setup Device
3. Select Advanced
4. Select Enable VPW console
5. Select Timestamps
6. Select Connect/Disconnect - It connects
7. Select Start Logging

No profile configured ...

Everything I try, I get No profile configured.

BTW, I do always delete it's %localappdata% data store, especially between versions.

[kur4o]

After connecting to device go to analyzer tab and start analyzer. It will open port and dump all traffic to console when enabled.
Current design will get better over time and easier to use, still polishing some leftover gremlins.

[Gampy]

Current design will get better over time and easier to use, still polishing some leftover gremlins.

Oh heck I understand that kur4o ... This ain't my first day.

If I'm dogging him, I apologize, that is not my intentions, my intentions are to help do exactly that, 'polish off the gremlins'.

If he is offended or hurt by my pointing this stuff out, I need to be told so I can change!

[kur4o]

You are stating the obvious and known stuff, so no offense here.
The polishing now is on the core functions, and that is the main focus.

About the logging error. Some pids need to be selected[profile tab] for logging to happen.

[Gampy]

I'm sorry, I did not know I was stating the obvious ... I will withhold my input!

I'm not logging Tuning parameters, I'm trying to log VPW traffic.

[kur4o]

The enable console checkbox was supposed to do something like that, but integration of other logging modes gives troubles. The idea of log traffic button seems great. Thanks for the input.