pcmhacking.net

Electronic Fuel Injection - Developement & Tuning
https://pcmhacking.net/forums/

PCM Logger 014 reading RAM addresses

https://pcmhacking.net/forums/viewtopic.php?t=7202

Page 2 of 3

Re: PCM Logger 014 reading RAM addresses

Posted: Tue May 04, 2021 3:47 am
by Gampy
Please open Parameters.Standard.xml, go to line number 1035 and change
byteCount="04"
to
storageType="uint16"
I seriously am taking a guess at the "uint16" from the fact it was x_high and x_low, for I truly do not know if that is the correct data size.

[edit]
However you are also correct in that it is also erroring on the x_high and x_low ...

[edit 2]
The expression for
EVAP Vent Solenoid Command
is missing, it has just an opening brace ( "(" ).
Being the math dummy I am I have no clue what the expression should be.

The expression for
TFP Sw
is also incomplete.

The expression for
Ethanol percentage
is missing braces ... I do not know if they are required, the rest do have them.

The expression for
Fuel Tank Pressure Sensor
has a stray "-" (negative symbol) in the expression.

[edit]
Removed incorrectly modified files ...

Re: PCM Logger 014 reading RAM addresses

Posted: Sun May 09, 2021 1:40 am
by turbotech
Hi,
I did a find and replace of ((x_high*256)+x_low) with x inParameters.Standard.xml in version 16E. PcmLogger would then load the file with out error. I also had to delete the Fuel gauge reporting since it used (x/x[2].....) which is now undefined. Using the uintX method will require someone to choose bytes within an X that is multibyte.

The results were:
PCM was reporting a value of x = 0xF081 = 240*256+129 = 61569 for engine run time. PcmLogger reported 33264. It seems like PcmLogger is not using the sign bit for a uint16 type.

PCM was reporting a value of x = 0xF082 = 240*256+130 = 61570 for mass air flow. PcmLogger reported 335.2 g/s. I was expecting 61570/100 = 615.70 g/s.

Re: PCM Logger 014 reading RAM addresses

Posted: Sun May 09, 2021 6:20 am
by Gampy
Bah, I see what I didn't understand! ... the ((x_high*256)+x_low), combines two 8bit values into one 16bit value, like ((value<<8) + value) in C ... Correct ??

Thus the Parameters.Standard.xml I posted is wrong ... for I changed ((x_high*256)+x_low) into (x*256).

This math dummy learned something ... Whoo Hoo!

Re: PCM Logger 014 reading RAM addresses

Posted: Mon May 10, 2021 2:38 pm
by NSFW
Thanks!

I just posted a "16F" zip file to the other thread: viewtopic.php?f=42&t=6688&p=107540#p107540

Please let me know if you find any more issues.

Re: PCM Logger 014 reading RAM addresses

Posted: Wed May 12, 2021 8:08 am
by turbotech
Hi,
I ran pcmLogger 16F with the files in the directory as is. The MAF g/s and Engine run time still don't seem to use the MSbit as an unsigned value.

The results are:

Re: PCM Logger 014 reading RAM addresses

Posted: Thu May 13, 2021 1:05 pm
by NSFW
Dang. Not sure where I went wrong, but I'll take another look.

Re: PCM Logger 014 reading RAM addresses

Posted: Thu May 13, 2021 10:47 pm
by Gampy
These are not causing that issue, however, they do need fixing ...

PID 1101 <Conversion units="Boolean" expression="(" format="0.00" />
PID 1112 <Conversion units="Boolean" expression="((x" format="0.00" />
PID 12E3 <Conversion units="mmHg" expression="-((x/5.46)-13.995)" format="0.00" />
PID 1481 <Conversion units="amps" expression="((((long)x_high*256)+x_low)/50)" format="0.00" />
PID 1482 <Conversion units="amps" expression="((((long)x_high*256)+x_low)/50)" format="0.00" />
PID 1484 <Conversion units="amps" expression="((((long)x_high*256)+x_low)/50)" format="0.00" />
PID 1485 <Conversion units="amps" expression="((((long)x_high*256)+x_low)/50)" format="0.00" />

Re: PCM Logger 014 reading RAM addresses

Posted: Fri May 14, 2021 5:13 pm
by NSFW
Yeah, those are clearly busted. Thanks!

Re: PCM Logger 014 reading RAM addresses

Posted: Sun May 16, 2021 1:39 pm
by NSFW
The logger defs are fixed, and I also added a bunch of parameters that were listed on a post at Gearhead-EFI.

But, I don't see what's wrong with the MAF sensor and run time parameters. Can you please post some data from the Debug pane?

Get the latest code. (Don't use the current code for this...)
viewtopic.php?f=42&t=6688&p=107666#p107666

Create and save an empty log profile. (I just fixed a bug related to creating new profiles.)

Open the log profile that has the MAF / run time issue, and log data until you hit the sign problem.

Select the empty log profile. (This stops the debug pane from scrolling.)

Then go to the debug pane.

Near the top, there will be a bunch of repeating pattersn of "TX" followed by "RX" followed by "Configured [parameter name]" Copy and paste all of those.

Near the end, there will be a log of repeating patterns with a TX line followed by one or more RX lines. Copy one of those (a TX and the following RX lines) from near the end.

The copied data should look something like this:

Code: Select all

[08:36:23:320]  TX: 2CFE4A0010FFFF 
[08:36:23:368]  RX: 6C F0 10 6C FE 4A
[08:36:23:369]  Configured MAF Sensor, g/s
[08:36:23:369]  TX: 2CFE5A000CFFFF 
[08:36:23:417]  RX: 6C F0 10 6C FE 5A
[08:36:23:417]  Configured Engine Speed, RPM
[08:36:23:417]  TX: 2CFE690004FFFF 
[08:36:23:467]  RX: 6C F0 10 6C FE 69
[08:36:23:467]  Configured Engine Load, %
[08:36:23:467]  TX: 2CFE71000BFFFF 
[08:36:23:518]  RX: 6C F0 10 6C FE 71
[08:36:23:518]  Configured MAP Sensor, kPa
[08:36:23:518]  TX: 2CFD491142FFFF 
[08:36:23:567]  RX: 6C F0 10 6C FD 49
[08:36:23:567]  Configured MAP Sensor, kpa?
[08:36:23:567]  TX: 2CFD5111A6FFFF 
[08:36:23:616]  RX: 6C F0 10 6C FD 51
[08:36:23:616]  Configured Knock Retard, °
[08:36:23:616]  TX: 2CFD59125DFFFF 
[08:36:23:671]  RX: 6C F0 10 7F 2C FD 59 12 5D FF 31
[08:36:23:671]  TX: 2CFD61125EFFFF 
[08:36:23:720]  RX: 6C F0 10 7F 2C FD 61 12 5E FF 31
[08:36:23:720]  TX: 2CFD691922FFFF 
[08:36:23:766]  RX: 6C F0 10 6C FD 69
[08:36:23:766]  Configured Power Enrichment, Boolean



[08:17:27:647]  TX: 2A01FEFD 
[08:17:27:745]  RX: 6C F0 10 6A FE 00 00 00 00 00 0A
[08:17:27:745]  RX: 6C F0 10 6A FD 00 00 01 01 01 00
And include a screenshot of the parameter names and values.
Thanks!

Re: PCM Logger 014 reading RAM addresses

Posted: Mon May 31, 2021 2:27 am
by turbotech
Hi,
Below are the results from PcmLogger 16I. I added the injector PW since it shows to be 10x in the reporting window.

Code: Select all

[12:14:10:498]  Device reset completed.
[12:14:14:593]  TX: 6C 10 F0 2C FE 4A 00 10 FF FF
[12:14:14:613]  RX: 6C F0 10 6C FE 4A
[12:14:14:613]  Configured MAF Sensor, g/s
[12:14:14:613]  TX: 6C 10 F0 2C FE 5A 11 A1 FF FF
[12:14:14:635]  RX: 6C F0 10 6C FE 5A
[12:14:14:635]  Configured Engine Run Time, Minutes
[12:14:14:635]  TX: 6C 10 F0 2C FE 6A 12 5A FF FF
[12:14:14:656]  RX: 6C F0 10 6C FE 6A
[12:14:14:656]  Configured Injector PWM Bank 1 Average, ms
[12:14:14:656]  TX: 6C 10 F0 2C FD 4A 12 5B FF FF
[12:14:14:686]  RX: 6C F0 10 6C FD 4A
[12:14:14:686]  Configured Injector PWM Bank 2 Average, ms
[12:14:14:686]  TX: 6C 10 F0 2C FD 5A 13 2A FF FF
[12:14:14:706]  RX: 6C F0 10 6C FD 5A
[12:14:14:706]  Configured Fuel Tank Level Remaining, Liters
[12:14:14:736]  TX: 6C 10 F0 2A 01 FE FD
[12:14:14:774]  RX: 6C F0 10 6A FE F0 82 F0 81 01 10
[12:14:14:790]  RX: 6C F0 10 6A FD 01 10 06 63 F6 F6
[12:14:14:852]  TX: 6C 10 F0 2A 01 FE FD
[12:14:14:890]  RX: 6C F0 10 6A FE F0 82 F0 81 01 10
[12:14:14:921]  RX: 6C F0 10 6A FD 01 0C 06 63 F6 F6
[12:14:14:921]  TX: 6C 10 F0 2A 01 FE FD
[12:14:14:975]  RX: 6C F0 10 6A FE F0 82 F0 81 01 0B
[12:14:14:990]  RX: 6C F0 10 6A FD 01 0B 06 63 F6 F6
[12:14:14:990]  TX: 6C 10 F0 2A 01 FE FD
[12:14:15:037]  RX: 6C F0 10 6A FE F0 82 F0 81 01 15
[12:14:15:075]  RX: 6C F0 10 6A FD 01 0B 06 63 F6 F6
[12:14:15:075]  TX: 6C 10 F0 2A 01 FE FD
All times are UTC+10:00
Page 2 of 3

Powered by phpBB® Forum Software © phpBB Limited