pcmhacking.net

Are you guys talking about the same thing? Read the voltage first yes - agree on that. But the doc does say DeviceID is the first argument, and it looks like ChannelID in the code. I think that part is a real bug.

It is DeviceID in PCM Hammer, github.com/LegacyNsfw/PcmHacks/Apps/PcmLibraryWindowsForms/Devices/J2534Device.cs#L399

It is deviceID in the code, Joukoy was suggesting it should be ChannelID but that is only the case when you are reading from other pins on the DLC after connecting to a protocol.

ok cool

NSFW, I just made a Pull request for PCMHammer to add support for a couple upcoming devices (VC and GT). Both have been tested with the latest commit.

I just put up RC4 with a change that I expect will fix data logging for J2534 devices. Instead of sending the usual "tool present" message with an 8C priority, the logger periodically sends "data logger present" (I made that up) which is basically the same thing but with a 6C priority. That way the PCM always sends log data with a 6C priority, and the original filter still works. That also let me remove a line of log message parsing code, so this approach is simpler all around.

I experiment with using 6C instead of 8C for all "tool present" messages but then my PCM wouldn't let me upload the kernel anymore. I switched them back to 8C and added some comments about the importance of 8C.

--

And then I saw Tazzi's pull request. Stay tuned for RC5.

RC5 is up.

NSFW wrote:RC5 is up.

Tested shortly with Vxdiag & OBDX pro: Logging & test write ok.

Still have this minimal problem: program must be restarted after selecting device, otherwise logging is halted.

I would suggest still calling the 6C message tool present, as tool present is what the command is and its what other literature refers too. You've changed the priority, lowering its priority from 8 (1000) to 6 (0111) which doesn't make any practical difference as I'm not aware of anything which actually reads a queue of messages then processes them in priority order instead of received order, but its still a 'tool present' message.

I keep hearing about some problem using J2534 devices, and I actually have two J2534 devices. In fact that is what I am doing all my testing with for the P10 and P12 PCMs. I haven't noticed any issues. What exactly was the issue?