Page 4 of 7

Re: Data logger for P01 and P59

Posted: Sat Feb 15, 2020 2:39 am
by joukoy
Version 9 works maybe one minute until it says "index out of bounds" or something.
But still, it works.

Version 11... see the log.
I believe this have something to do with regional settings (?)

Edit:
System.IO.DirectoryNotFoundException: Polun C:\Users\Jouko\Documents\20200213_1703_General.json.csv osaa ei löytynyt.
in English:
System.IO.DirectoryNotFoundException: Path C:\Users\Jouko\Documents\20200213_1703_General.json.csv part not found.

Re: Data logger for P01 and P59

Posted: Sat Feb 15, 2020 7:23 am
by NSFW
It should be possible to fix that by clicking the "Set Folder" button and choosing a valid directory.

What is your "Documents" directory really named? I'll report this bug to Microsoft, because the app uses an API that is supposed to honor regional settings:

Code: Select all

            string logDirectory = LoggerConfiguration.LogDirectory;
            if (string.IsNullOrWhiteSpace(logDirectory))
            {
                logDirectory = Environment.GetFolderPath(Environment.SpecialFolder.MyDocuments);
                LoggerConfiguration.LogDirectory = logDirectory;
            }

Re: Data logger for P01 and P59

Posted: Sat Feb 15, 2020 10:16 am
by Gampy
joukoy,

What Operating System??
Are you running it in a Virtual Machine??

Re: Data logger for P01 and P59

Posted: Sat Feb 15, 2020 4:13 pm
by joukoy
joukoy wrote:Version 9 works maybe one minute until it says "index out of bounds" or something.
But still, it works.

Version 11... see the log.
I believe this have something to do with regional settings (?)

Edit:
System.IO.DirectoryNotFoundException: Polun C:\Users\Jouko\Documents\20200213_1703_General.json.csv osaa ei löytynyt.
in English:
System.IO.DirectoryNotFoundException: Path C:\Users\Jouko\Documents\20200213_1703_General.json.csv part not found.
SORRY!
False alarm, I copied folder from one computer to another and didn't change folder at any moment.
It was automatically set to C:\Users\Jouko\Documents\ in first pc, but then logged on with different username on second computer.

Now it works fine.

Re: Data logger for P01 and P59

Posted: Sat Feb 15, 2020 6:30 pm
by NSFW
Glad to hear it!

Re: Data logger for P01 and P59

Posted: Tue Feb 25, 2020 5:04 pm
by joukoy
Scott68B wrote:Had a chance to play with it further this weekend. I was out for over an hour drive yesterday with no issues and went for another drive today. I encountered the following. Hope it is of some help.

Scott

Code: Select all

[02:26:59:080]  TX: 2A01FEFDFC 
[02:26:59:240]  RX: 6C F0 10 6A FE 24 D7 0A B9 02 02
[02:26:59:240]  RX: 6C F0 10 6A FD AB 7B 59 FF 16 CF
[02:26:59:240]  RX: 6C F0 10 6A FC 8B 7A 8B 7C 79 1C
[02:26:59:240]  ReadLogData: 6C F0 10 6A FE 24 D7 0A B9 02 02
[02:26:59:240]  ReadLogData: 6C F0 10 6A FD AB 7B 59 FF 16 CF
[02:26:59:240]  ReadLogData: 6C F0 10 6A FC 8B 7A 8B 7C 79 1C
[02:26:59:240]  Requesting row...
[02:26:59:240]  TX: 2A01FEFDFC 
[02:26:59:419]  RX: 6C F0 10 6A FE 24 DA 09 D4 02 02
[02:26:59:419]  RX: 6C F0 10 6A FD 6D 79 58 FF 16 CF
[02:26:59:419]  RX: 6C F0 10 6A FC 8B 80 8B 7B 79 1B
[02:26:59:419]  ReadLogData: 6C F0 10 6A FE 24 DA 09 D4 02 02
[02:26:59:419]  ReadLogData: 6C F0 10 6A FD 6D 79 58 FF 16 CF
[02:26:59:419]  ReadLogData: 6C F0 10 6A FC 8B 80 8B 7B 79 1B
[02:26:59:423]  Requesting row...
[02:26:59:423]  TX: 2A01FEFDFC 
[02:26:59:591]  RX: 6C F0 10 6A
[02:26:59:591]  RX: 6C F0 10 6A FD 20 80 5A FF 14 CF
[02:26:59:591]  RX: 6C F0 10 6A FC 8B 80 8B 80 79 1B
[02:26:59:591]  ReadLogData: 6C F0 10 6A
[02:26:59:624]  System.IndexOutOfRangeException: Index was outside the bounds of the array.
   at PcmHacking.Message.get_Item(Int32 index)
   at PcmHacking.Protocol.TryParseRawLogData(Message message, RawLogData& rawLogData)
   at PcmHacking.Vehicle.<ReadLogData>d__46.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
   at PcmHacking.Logger.<GetNextRow>d__5.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
   at PcmHacking.MainForm.<LoggingThread>d__23.MoveNext() in C:\GitHub\PcmHacks\Apps\PcmLogger\MainForm.cs:line 287
In what version this is fixed?
Pcmhammer 11, pcmlogger can run only few minutes and then:

Code: Select all

[01.31.17.022]  Requesting row...
[01.31.17.022]  TX: STPX H:6C10F0, R:2, D:2A01FEFD
[01.31.17.132]  RX: 6C F0 10 6A FE 08 8F 02 75 26 0C
[01.31.17.132]  RX: 6C F0 10 6A
[01.31.17.132]  ReadLogData: 6C F0 10 6A FE 08 8F 02 75 26 0C
[01.31.17.132]  ReadLogData: 6C F0 10 6A
[01.31.17.163]  System.IndexOutOfRangeException: Indeksi oli taulukon alueen ulkopuolella.
   kohteessa PcmHacking.Message.get_Item(Int32 index)
   kohteessa PcmHacking.Protocol.TryParseRawLogData(Message message, RawLogData& rawLogData)
   kohteessa PcmHacking.Vehicle.<ReadLogData>d__45.MoveNext()
--- Pinon jäljityksen loppu aiemmasta sijainnista, jossa palautettiin poikkeus ---
   kohteessa System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   kohteessa System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   kohteessa System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
   kohteessa PcmHacking.Logger.<GetNextRow>d__5.MoveNext()
--- Pinon jäljityksen loppu aiemmasta sijainnista, jossa palautettiin poikkeus ---
   kohteessa System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   kohteessa System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   kohteessa System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
   kohteessa PcmHacking.MainForm.<LoggingThread>d__25.MoveNext() tiedostossa C:\GitHub\PcmHacks\Apps\PcmLogger\MainForm.cs:rivillä 342
[01.31.20.426]  TX: STPX H:6C10F0, R:2, D:2CFE4A000CFFFF


Re: Data logger for P01 and P59

Posted: Fri Feb 28, 2020 4:43 pm
by NSFW
The fix will be in 12.

Re: Data logger for P01 and P59

Posted: Tue May 12, 2020 10:32 pm
by brandonwh64
This logger has been working great for me. Using https://datazap.me/ allows you to put these log files into graph/timeline form.

Now I was wondering if anyone has compiled a list of PIDs for the P01/P59 along with their descriptions? Would like to log your VE table/TAFR while you drive and it log RPM at the same time which is already a possibility but I do not know the VE table PID. I got the torque app to log VE but it does not give the PID it uses.

Re: Data logger for P01 and P59

Posted: Tue Jul 07, 2020 1:59 pm
by turbo_v6
I'm interested in increasing the speed of logging. I'm using hptuners for my logging right now, and it's quite a low logging rate. Also I think being able to add my own parameters via memory addresses would be a big help in terms of reverse engineering the OS.

I can't really help with the development of the software, but I can support doing testing.

I was thinking of doing a baseline of logging speed. Not sure how I should do that but I figured it would be good to have.

Re: Data logger for P01 and P59

Posted: Wed Jul 08, 2020 6:09 am
by jlvaldez
Remember the data bus is a pretty abysmally slow 10.4 kbps, and has lots of other data to transfer too. Higher data rates are simply not possible if you're logging several PIDs