Page 8 of 19

Re: PCM Hammer Suite development

Posted: Thu May 21, 2020 1:25 am
by Gampy
Just to put my PR#171 dilemma out there ... I pondered that or this,

Code: Select all

diff --git a/Apps/PcmLibrary/CKernelWriter.cs b/Apps/PcmLibrary/CKernelWriter.cs
index 68f5750..8c62040 100644
--- a/Apps/PcmLibrary/CKernelWriter.cs
+++ b/Apps/PcmLibrary/CKernelWriter.cs
@@ -254,7 +254,7 @@ namespace PcmHacking
                         {
                             Utility.ReportRetryCount("Write", messageRetryCount, flashChip.Size, this.logger);
                         }
-                        return true;
+                        break;
                     }
                 }

@@ -341,11 +341,6 @@ namespace PcmHacking
             {
                 this.logger.AddUserMessage("Flash successful!");

-                if (messageRetryCount > 2)
-                {
-                    logger.AddUserMessage("Write request messages had to be re-sent " + messageRetryCount + " times.");
-                }
-
                 return true;
             }

Re: PCM Hammer Suite development

Posted: Thu May 21, 2020 5:38 am
by Gampy
Bah humbug, I just realized my PR#175 (now merged) conflicted with my previously existing PR#168.

I have updated PR#168, my apologies.

Re: PCM Hammer Suite development

Posted: Wed Aug 19, 2020 8:14 am
by Gampy
I have a User Defined Key feature ready to release that will cover this Added ability to unlock PCM with erased parameter block. #181 PR by dzidaV8.

Just waiting on prerequisites and or conflicts to either be merged or rejected.

At the moment it's third in queue.

-Enjoy

Re: PCM Hammer Suite development

Posted: Wed Aug 19, 2020 4:44 pm
by antus
Cool looks good!

Re: PCM Hammer Suite development

Posted: Fri Aug 21, 2020 3:09 pm
by NSFW
Sorry I've been out of the loop lately, I'll find some time for these pull requests this weekend.

Re: PCM Hammer Suite development

Posted: Fri Aug 28, 2020 1:47 pm
by NSFW
That weekend sure went by quickly. :O

Maybe this weekend...

Re: PCM Hammer Suite development

Posted: Fri Aug 28, 2020 9:14 pm
by Gampy
Time flies when you're having fun ...

Re: PCM Hammer Suite development

Posted: Mon Aug 31, 2020 5:37 pm
by Gampy
So what's happening with PR 160, 168, 169, 171, are they being silently pondered, or silently rejected??

Would be nice to know so adjustments can be made accordingly to move forward, progress is being held up.

Re: PCM Hammer Suite development

Posted: Tue Sep 01, 2020 1:37 pm
by NSFW
It's not you, it's me! I was looking at the "flash successful redux" change when I got derailed. I'll get back to it.

Re: PCM Hammer Suite development

Posted: Tue Sep 01, 2020 2:09 pm
by Gampy
Thank you very much for letting me know ...

That's life, it happens!

Just to reiterate my own dilemma on that (flash successful redux) PR #171 See This

-Enjoy