Data logger for P01 and P59

They go by many names, P01, P59, VPW, '0411 etc . Circa 1999 to 2006. All VPW OBD2 PCMs.
Posts: 12
Joined: Sat Aug 29, 2009 9:52 pm

Re: Data logger for P01 and P59

Postby Scott68B » Fri Nov 29, 2019 3:15 pm

Very nice! It seems to be capturing data several times per second. It looks pretty easy to configure more PIDs as well. I really like it!

Thank you NSFW!!

Posts: 187
Joined: Sat Dec 15, 2018 7:38 am

Re: Data logger for P01 and P59

Postby Gampy » Sat Nov 30, 2019 8:49 am

In PcmLogger
Code: Select all
private string GenerateLogFilePath()

Could we please change this
Code: Select all
string directory = Environment.GetEnvironmentVariable("USERPROFILE");

to this
Code: Select all
string directory = Path.Combine(Environment.ExpandEnvironmentVariables("%userprofile%"), "Documents");

Or for that matter replace GenerateLogFilePath() with this
Code: Select all
        private string GenerateLogFilePath()
        {
            return Path.Combine(Environment.ExpandEnvironmentVariables("%userprofile%"),
                "Documents",
                DateTime.Now.ToString("yyyyMMdd_HHmm") +
                  "_" +
                  this.profileName +
                  ".csv"
                );
        }


Thanks for doing what ya do!

User avatar
Posts: 220
Joined: Fri Feb 02, 2018 3:13 pm

Re: Data logger for P01 and P59

Postby NSFW » Sat Nov 30, 2019 10:23 am

Thing is, it's only named Documents if you installed Windows in English. :)

However I just did some searching, and there's an API to get the path regardless of the language. I'll use that.

https://docs.microsoft.com/en-us/dotnet ... mework-4.8
Please don't PM me with questions about tuning or flashing - start a thread instead. Thanks!

Posts: 187
Joined: Sat Dec 15, 2018 7:38 am

Re: Data logger for P01 and P59

Postby Gampy » Sat Nov 30, 2019 10:27 am

That's why you get paid the big bux!

I didn't even think of that, selfish me!

How about a directory picker instead?

[edit]
In case you haven't spent the time already ...
replace
Code: Select all
            string directory = Environment.GetEnvironmentVariable("USERPROFILE");

With
Code: Select all
            string directory = Environment.GetFolderPath(Environment.SpecialFolder.MyDocuments);

Posts: 12
Joined: Sat Aug 29, 2009 9:52 pm

Re: Data logger for P01 and P59

Postby Scott68B » Sun Dec 01, 2019 2:35 am

Had an issue this morning that I thought I'd report. This happened a couple of times and I did not restart the app in between tries. Might be nothing.

Code: Select all
[10:20:23:788]  ReadLogData: 6C F0 10 6A FE 0C 9C 02 86 02 02
[10:20:23:788]  ReadLogData: 6C F0 10 6A FD AE 7C 59 FF 00 AA
[10:20:23:788]  ReadLogData: 6C F0 10 6A FC 94 7C 7C 3C 94 7D
[10:20:23:790]  Requesting row...
[10:20:23:790]  TX: 2A01FEFDFC
[10:20:23:937]  RX: 6C F0 10 6A FE 0C 99 02 76 02 02
[10:20:23:937]  RX: 6C F0 10 6A FD B0 7C 5A FF 00 AA
[10:20:23:937]  RX: 6C F0 10 6A FC 94 7C 7C 3C 94 7D
[10:20:23:937]  ReadLogData: 6C F0 10 6A FE 0C 99 02 76 02 02
[10:20:23:937]  ReadLogData: 6C F0 10 6A FD B0 7C 5A FF 00 AA
[10:20:23:937]  ReadLogData: 6C F0 10 6A FC 94 7C 7C 3C 94 7D
[10:20:23:937]  Requesting row...
[10:20:23:937]  TX: 2A01FEFDFC
[10:20:24:098]  RX: 6C F0 10 6A FE 0C A8 02 95 02 02
[10:20:24:098]  RX: 6C F0 10 6A FD B2 7C 5B FF 00
[10:20:24:098]  RX: 6C F0 10 6A FC 94 7C 7C 3C 94 7C
[10:20:24:098]  ReadLogData: 6C F0 10 6A FE 0C A8 02 95 02 02
[10:20:24:098]  ReadLogData: 6C F0 10 6A FD B2 7C 5B FF 00
[10:20:24:098]  ReadLogData: 6C F0 10 6A FC 94 7C 7C 3C 94 7C
[10:20:24:098]  System.IndexOutOfRangeException: Index was outside the bounds of the array.
   at PcmHacking.LogRowParser.EvaluateDpidMessage(ParameterGroup group, Byte[] payload, List`1 result)
   at PcmHacking.LogRowParser.Evaluate()
   at PcmHacking.Logger.<GetNextRow>d__5.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
   at PcmHacking.MainForm.<LoggingThread>d__23.MoveNext() in C:\GitHub\PcmHacks\Apps\PcmLogger\MainForm.cs:line 275

User avatar
Posts: 220
Joined: Fri Feb 02, 2018 3:13 pm

Re: Data logger for P01 and P59

Postby NSFW » Sun Dec 01, 2019 3:32 am

Thanks, that's a bug. The FD response was one byte too short, and the app shouldn't blow up when that happens.
Please don't PM me with questions about tuning or flashing - start a thread instead. Thanks!

Previous

Return to GM LS1 512Kbyte and 1Mbyte

Who is online

Users browsing this forum: MSN [Bot] and 3 guests