PCM Hammer Release 014

They go by many names, P01, P59, VPW, '0411 etc . Circa 1999 to 2006. All VPW OBD2 PCMs.
Posts: 35
Joined: Tue Dec 31, 2019 11:24 am

Re: PCM Hammer Release 014

Postby ColPaul » Wed Jul 29, 2020 9:55 am

When I download the entire PCM with PCMHammer v12, it works. I attached the log file to compare where the PCMHammer v14 fails. The relevant section is also below.
[06:10:06:260] 0x0FE000 99% 00:01
[06:10:07:166] 0x0FF000 99% 00:00
[06:10:07:182] Read complete.
[06:10:07:198] All write-request messages succeeded on the first try. You have an excellent connection to the PCM.
[06:10:07:213] We're not sure how much retrying is normal for a read operation on a 1024kb PCM.
[06:10:07:213] Please help by sharing your results in the PCM Hammer thread at pcmhacking.net.
[06:10:07:244] Starting verification...
[06:10:07:260] Calculating CRCs from file...
[06:10:07:276] Requesting CRCs from PCM...
[06:10:07:338] Range File CRC PCM CRC Verdict Purpose
[06:10:10:450] 0E0000-0FFFFF A873B6D7 A873B6D7 Same OperatingSystem
[06:10:13:559] 0C0000-0DFFFF 807305D6 807305D6 Same OperatingSystem
[06:10:16:669] 0A0000-0BFFFF 807305D6 807305D6 Same OperatingSystem
[06:10:19:794] 080000-09FFFF CA3CB0F4 CA3CB0F4 Same OperatingSystem
[06:10:22:903] 060000-07FFFF 9A433D6B 9A433D6B Same OperatingSystem
[06:10:26:028] 040000-05FFFF 635F236F 635F236F Same OperatingSystem
[06:10:29:153] 020000-03FFFF 9667FFB0 9667FFB0 Same OperatingSystem
[06:10:30:731] 008000-01FFFF 74C8B461 74C8B461 Same Calibration
[06:10:32:340] 006000-007FFF 3D8662C5 3D8662C5 Same Parameter
[06:10:33:934] 004000-005FFF 85B5BB36 85B5BB36 Same Parameter
[06:10:35:543] 000000-003FFF 6A096F07 6A096F07 Same Boot
[06:10:35:590] The contents of the file match the contents of the PCM.
[06:10:35:653] Clearing trouble codes.
[06:10:36:215] Clearing trouble codes.
[06:10:36:794] Elapsed time 00:04:27.4093356
[06:10:36:840] Saving contents to C:\Users\Paul\Documents\S10 Baseline.bin.2nd.bin
Attachments
PCMHammer12.log
(12 KiB) Downloaded 30 times

User avatar
Posts: 726
Joined: Sat Dec 15, 2018 7:38 am

Re: PCM Hammer Release 014

Postby Gampy » Wed Jul 29, 2020 10:28 am

If you have a different tool, try it.
Temporary is a permanent problem!

Posts: 35
Joined: Tue Dec 31, 2019 11:24 am

Re: PCM Hammer Release 014

Postby ColPaul » Wed Jul 29, 2020 11:00 am

I have some generic ELM adapter that I can try, but I have run the download PCM at least 4 times from PCMHammer V12 and V14. Each time V14 fails and V12 passes. In addition, I replicated the same results on another/newer MacBook Pro, also running Windows 10. I guess I'll go look at the code around the "Clearing trouble codes." log output to see if there is any differences. I'll probably rerun V14 and look at the lower level debugging info vs. just the output window.

User avatar
Posts: 726
Joined: Sat Dec 15, 2018 7:38 am

Re: PCM Hammer Release 014

Postby Gampy » Wed Jul 29, 2020 11:39 am

The failure point is specific to that device ... In OBDXProDevice.cs.
Temporary is a permanent problem!

Posts: 35
Joined: Tue Dec 31, 2019 11:24 am

Re: PCM Hammer Release 014

Postby ColPaul » Wed Jul 29, 2020 12:15 pm

Thanks! I'll start looking there and see if I can find the source.

Site Admin
User avatar
Posts: 6323
Joined: Sat Feb 28, 2009 8:34 pm

Re: PCM Hammer Release 014

Postby antus » Wed Jul 29, 2020 2:44 pm

I sent out a ping to the xpro guys, they can take a look at this. Is the file still saved? Its a good read, but there is something going on at the end there. Adapters based on the original elm chip cant be used with pcmhammer. They can not handle the long messages required.
Have you read the FAQ? For lots of information and links to significant threads see here: viewtopic.php?f=7&t=1396

User avatar
Posts: 726
Joined: Sat Dec 15, 2018 7:38 am

Re: PCM Hammer Release 014

Postby Gampy » Wed Jul 29, 2020 3:33 pm

ColPaul wrote:When I try to download the entire PCM, it works but then fails after "Clearing trouble codes." and doesn't save the file.

Rightfully so, as the first call to Cleanup is prior to file save ...

IMO it seems the file save should be closer to the actual finish of the reading, maybe just after file verification, before anything else ... Not sure, need to look at the code first.
I'm pretty sure it needs info (filename) from Mainform, maybe a Filename property in CKernelReader is the ticket ... Just thinking out loud!
Temporary is a permanent problem!

Site Admin
User avatar
Posts: 6323
Joined: Sat Feb 28, 2009 8:34 pm

Re: PCM Hammer Release 014

Postby antus » Wed Jul 29, 2020 4:01 pm

Yeah I think it needs to do the save if the read completes successfully, regardless of if clear dtcs is successful or not. There is still another problem here - it shouldnt fail like that, but if we handled it differently at least it would be a show stopper.
Have you read the FAQ? For lots of information and links to significant threads see here: viewtopic.php?f=7&t=1396

User avatar
Posts: 726
Joined: Sat Dec 15, 2018 7:38 am

Re: PCM Hammer Release 014

Postby Gampy » Wed Jul 29, 2020 10:03 pm

No doubt there is a brokenness in the OBDXPro code that needs fixing ... I don't have one or I would debug it. I don't see any obvious bugs ...

As for saving earlier, after a quick look, I believe I see the reason it is the way it is, NSFW designed the Library to be OS independent, file saving is OS dependent, thus moving the save earlier would break the OS independence of the library.
I'm sure there is a way around this, I don't see it at the moment ...
Temporary is a permanent problem!

Posts: 35
Joined: Tue Dec 31, 2019 11:24 am

Re: PCM Hammer Release 014

Postby ColPaul » Thu Jul 30, 2020 6:46 am

I reran both V12 and V14 to capture the debugging log.

V12
...
[03:32:48:472] The contents of the file match the contents of the PCM.
[03:32:48:481] Halting the kernel.
[03:32:48:486] DVI setting VPW 1X
[03:32:48:498] Clearing trouble codes.
[03:32:49:029] Halting the kernel.
[03:32:49:035] DVI setting VPW 4X
[03:32:49:042] DVI setting VPW 1X
[03:32:49:052] Clearing trouble codes.
[03:32:49:588] Elapsed time 00:04:33.0916088
[03:32:49:600] Saving contents to C:\Users\Paul\Desktop\test.v12.bin


v14
..
[03:25:08:528] The contents of the file match the contents of the PCM.
[03:25:08:543] Halting the kernel.
[03:25:08:543] XPro: 20 01 00 DE
[03:25:08:543] TX: 6C 10 F0 20
[03:25:08:543] DVI setting VPW 1X
[03:25:08:543] XPro: 43 02 06 00 B4
[03:25:08:559] XPro: 20 01 00 DE
[03:25:08:559] TX: 6C 10 F0 20
[03:25:08:559] Clearing trouble codes.
[03:25:08:857] XPro: 20 01 00 DE
[03:25:08:857] TX: 68 6A F0 04
[03:25:09:122] XPro: 20 01 00 DE
[03:25:09:122] TX: 68 6A F0 04
[03:25:09:403] XPro: 20 01 00 DE
[03:25:09:403] TX: 8C FE F0 14
[03:25:09:669] XPro: 20 01 00 DE
[03:25:09:669] TX: 8C FE F0 14
[03:25:09:669] Halting the kernel.
[03:25:09:669] DVI setting VPW 4X
[03:25:09:715] Read failed: System.NullReferenceException: Object reference not set to an instance of an object.
at PcmHacking.OBDXProDevice.<FindResponseFromTool>d__56.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
at PcmHacking.OBDXProDevice.<SetVpwSpeedInternal>d__71.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
at PcmHacking.Device.<SetVpwSpeed>d__37.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
at PcmHacking.Vehicle.<ExitKernel>d__34.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.GetResult()
at PcmHacking.Vehicle.<Cleanup>d__33.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.GetResult()
at PcmHacking.CKernelReader.<ReadContents>d__4.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
at PcmHacking.MainForm.<readFullContents_BackgroundThread>d__36.MoveNext() in C:\GitHub\PcmHacks\Apps\PcmHammer\MainForm.cs:line 839

PreviousNext

Return to GM LS1 512Kbyte and 1Mbyte

Who is online

Users browsing this forum: No registered users and 2 guests