Two PRs related to CAN logging

They go by many names, P01, P10, P12, P59, E38, VPW, '0411 etc.
Post Reply
User avatar
NSFW
Posts: 758
Joined: Fri Feb 02, 2018 3:13 pm

Two PRs related to CAN logging

Post by NSFW »

This one is small, it just adds some logging to show what messages it finds on CAN bus at the start of a logging session:
https://github.com/PcmHammer/PcmHammer/pull/12

This one is bigger:
https://github.com/PcmHammer/PcmHammer/pull/13
  • It can now extract multiple parameters from a single CAN message. (This was the intent from the start, but wasn't finished.)
  • CAN messages can arrive at a higher frequency than PCM data, and now it can average the data that it received, or just take the last one. I think averaging might help for AFR in particular.
  • Fixes a couple bugs in CAN message parsing.
  • Adds some unit tests for CAN message parsing.
I just noticed that the Windows version we've been using for the CI builds (2019) is no longer supported, and the newer Windows releases don't have .Net 4.6.1. Looks like we can use 4.6.2 though so I'm trying that.

https://github.com/PcmHammer/PcmHammer/ ... 8532?pr=13
Please don't PM me with technical questions - start a thread instead, and send me a link to it. That way I can answer in public, and help other people who have the same question. Thanks!
User avatar
NSFW
Posts: 758
Joined: Fri Feb 02, 2018 3:13 pm

Re: Two PRs related to CAN logging

Post by NSFW »

The 4.6.2 upgrade touched a lot of generated files in addition to the .csproj files, so I made a third PR for that:

https://github.com/PcmHammer/PcmHammer/pull/14

After this is merged, I'll update the other two so that their CI builds will pass too.

I just learned more about .Net installers than I ever wanted to know. :)
Please don't PM me with technical questions - start a thread instead, and send me a link to it. That way I can answer in public, and help other people who have the same question. Thanks!
User avatar
antus
Site Admin
Posts: 9040
Joined: Sat Feb 28, 2009 8:34 pm
cars: TX Gemini 2L Twincam
TX Gemini SR20 18psi
Datsun 1200 Ute
Subaru Blitzen '06 EZ30 4th gen, 3.0R Spec B
Contact:

Re: Two PRs related to CAN logging

Post by antus »

Good stuff. I tried 4.6.2 and got in to a world of pain and moved to 4.8 instead. But i'll throw that away as 4.6.2 is a better target for now. Hopefully the readme explain how to configure the OS for the build. I was also testing on studi 2022, not sure if that was part of the problem but it couldntvsee the 4.6.2 sdk installed with what I tried.
Have you read the FAQ? For lots of information and links to significant threads see here: http://pcmhacking.net/forums/viewtopic.php?f=7&t=1396
User avatar
NSFW
Posts: 758
Joined: Fri Feb 02, 2018 3:13 pm

Re: Two PRs related to CAN logging

Post by NSFW »

I updated the readme to add instructions for both users and contributors. I'm using 2022 and it's working for me, but they have been putting out incremental updates pretty frequently and I think they fixed something in this area. I ran into a bunch of headaches when I tried to change the .Net version last fall, but this time it went smoothly.
Please don't PM me with technical questions - start a thread instead, and send me a link to it. That way I can answer in public, and help other people who have the same question. Thanks!
Post Reply