Feel free to continue to work on it add to add or change anything, the branch is up here https://github.com/LegacyNsfw/PcmHacks/tree/antus/p12
We need to get those #ifs out and make the pcminfo data available to the messages or protocol so we can switch between the different pcm type logic at runtime where we need it. I think that means doing something like this https://github.com/LegacyNsfw/PcmHacks/ ... ter.cs#L25 in those other classes and passing the needed info in. Send me a PM if you start working on the branch, so I dont do anything that'll clash before you push changes.
antus wrote:We need to get those #ifs out and make the pcminfo data available to the messages or protocol so we can switch between the different pcm type logic at runtime where we need it.
Why, I thought the pre processor directives was an excellent production technique ... Twice the work, twice the nightmare, keeps people working and happy!
Intelligence is in the details!
It is easier not to learn bad habits, then it is to break them!
If I was here to win a popularity contest, their would be no point, so I wouldn't be here!
Thanks for the Pull request Gampy, Ive merged your P10 and P12 kernel build system work in to the antus/p12 branch for inclusion in to the app hopefully soonish. It looks like we can get the P10 and P12 supported together at the same time now.
I've created a PR to merge some minor changes into antus/p12.
The p10/p12 stuff looks good, I'm fine with merging it all into develop.
Please don't PM me with technical questions - start a thread instead, and send me a link to it. That way I can answer in public, and help other people who have the same question. Thanks!
Dont worry, the testing is implied, and develop gets testing before release also. I can test on P01/P59/P12. If they all work and we add something to omit the top 512kb for the P10, it should be good, but darkman should be able to test P10.
Well Ive got all the code merged to p12 and some more of my own changes, and it all works on my P12 and P59. Ive sent a test build to a couple of members who said they had P10s. We still need to get checksums figured out for P10 and P12 so we can validate bin files are safe before flashing, which might take a bit of work but then I think we'll be good to submit for the next release.
@Gampy - Your comment had me thinking there was some kind of challenge in there, and I had 2 failed kernel uploads, which I cant explain any other way than possibly EMI from my shed fridge over long cables, and which took me a while to confirm. If you know of anything thats missed in the branch under testing it would be helpful for you to tell us. I have found and fixed the wrong block type in the validate upload response for P01/P59.
